Standalone viewer app defaults to downsample on Z #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of the unit tests are also using 'int' instead of 'round' which is why the gh-actions are failing. |
Merged
|
This PR fixes #359 by moving some functionality to |
There was a problem hiding this comment.
I approve of the changes, except when I run locally I get the error:
_______________________________ TestViewerMainWindow.test_all ________________________________
self = <test.test_viewer_main_windows.TestViewerMainWindow testMethod=test_all>
def test_all(self):
global _instance
if _instance is None:
> _instance = QApplication(sys.argv)
E RuntimeError: Please destroy the QApplication singleton before creating a new QApplication instance.
test_viewer_main_windows.py:42: RuntimeError
FAILED test_viewer_main_windows.py::TestViewerMainWindow::test_all - RuntimeError: Please destroy the QApplication singleton before creating a new QApplication...
|
Possibly the failure is due to #367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standalone app now defaults to downsample in all 3 dimensions, unless it's loading an HDF5 where it can infer that we are importing acquisition data.
closes #359