Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[get-uri] Update 'st' from v1 to v3 #336

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

mxschmitt
Copy link
Contributor

@mxschmitt mxschmitt commented Sep 30, 2024

Before it was throwing this during the get-uri tests, this version bump fixes it:

(node:20556) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.
    at set (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/st@1.2.2/node_modules/st/st.js:137:31)
    at Mount.Object.<anonymous>.Mount.getCacheOptions (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/st@1.2.2/node_modules/st/st.js:150:9)
    at new Mount (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/st@1.2.2/node_modules/st/st.js:99:16)
    at st (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/st@1.2.2/node_modules/st/st.js:79:11)
    at Object.<anonymous> (/Users/maxschmitt/Developer/tmp/proxy-agents/packages/get-uri/test/https.test.ts:21:43)
    at Promise.then.completed (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/jest-circus@29.5.0/node_modules/jest-circus/build/utils.js:293:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/jest-circus@29.5.0/node_modules/jest-circus/build/utils.js:226:10)
    at _callCircusHook (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/jest-circus@29.5.0/node_modules/jest-circus/build/run.js:262:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTestsForDescribeBlock (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/jest-circus@29.5.0/node_modules/jest-circus/build/run.js:92:7)
    at _runTestsForDescribeBlock (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/jest-circus@29.5.0/node_modules/jest-circus/build/run.js:130:9)
    at _runTestsForDescribeBlock (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/jest-circus@29.5.0/node_modules/jest-circus/build/run.js:130:9)
    at run (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/jest-circus@29.5.0/node_modules/jest-circus/build/run.js:68:3)
    at runAndTransformResultsToJestFormat (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/jest-circus@29.5.0/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/jest-circus@29.5.0/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/jest-runner@29.5.0/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/jest-runner@29.5.0/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/Users/maxschmitt/Developer/tmp/proxy-agents/node_modules/.pnpm/jest-runner@29.5.0/node_modules/jest-runner/build/testWorker.js:106:12)

Its a dependency which is only used inside the tests - hence I didn't create a changeset.

Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: 157d08d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
proxy-agents ✅ Ready (Inspect) Visit Preview Oct 21, 2024 9:11pm

@TooTallNate TooTallNate changed the title chore: bump 'st' from v1 to v3 [get-uri] Update 'st' from v1 to v3 Oct 21, 2024
@TooTallNate TooTallNate merged commit 7d4bd26 into TooTallNate:main Oct 21, 2024
14 checks passed
@TooTallNate
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants