Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard #68

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Dashboard #68

wants to merge 24 commits into from

Conversation

ryanhayame
Copy link
Contributor

@ryanhayame ryanhayame commented Oct 22, 2024

Created localhost dashboard to manage skypilot/kubernetes/kueue workloads.

Features include:

  1. Grafana konduktor dashboard embedding
  2. Loki live logs (search + filtering by namespace)
  3. Kueue UI to view, delete, and modify priority of workloads

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)

(you should review kube-prometheus-stack.values changes closely)

Copy link
Contributor

@asaiacai asaiacai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. left some comments mostly around moving stuff around.

konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/main.py Outdated Show resolved Hide resolved
konduktor/dashboard/backend/requirements.txt Outdated Show resolved Hide resolved
konduktor/dashboard/backend/Dockerfile Outdated Show resolved Hide resolved
konduktor/dashboard/frontend/Dockerfile Outdated Show resolved Hide resolved
konduktor/dashboard/frontend/README.md Outdated Show resolved Hide resolved
@Trainy-ai Trainy-ai deleted a comment from sweep-ai bot Nov 5, 2024
Copy link

sweep-ai bot commented Nov 5, 2024

Hey @ryanhayame, here is an example of how you can ask me to improve this pull request:

@Sweep Add unit tests for the `format_log_entry` function in `konduktor/dashboard/backend/sockets.py` to verify correct timestamp conversion and log message formatting.

📖 For more information on how to use Sweep, please read our documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants