Set pickup/drop_off _type on in-seat transfers #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a transfer is in_seat, passengers should be able to embark at the last stop of the from_trip of the continuation, and disembark at the first stop of the to_trip of the continuation. Update the stop_times to reflect this. Update a simple test case to ensure that this transformation is applied.
npaun
reviewed
Mar 20, 2024
| to_trip_ids_to_set.add(to_trip_id) | ||
|
|
||
| for trip_id in from_trip_ids_to_set: | ||
| gtfs.stop_times.get(trip_id)[-1].pickup_type = PickupType.REGULARLY_SCHEDULED |
There was a problem hiding this comment.
I don't think it's necessary to use a set to collect trip_ids. You can directly manipulate gtfs.stop_times[from_trip_id] or to_trip_id in the innermost loop.
Regardless, .get(trip_id) should be replaced with [trip_id] this is because .get returns None for unset keys, and will then lead to an exception when you try to operate on it. The brackets will immediately raise an exception indicating that trip_id wasn't found, which is actually the underlying issue.
…ectly assigned in split-trip cases
npaun
reviewed
Mar 20, 2024
Comment on lines
4
to
5
| from_trip_ids_to_set = set() | ||
| to_trip_ids_to_set = set() |
There was a problem hiding this comment.
These variables have now become unused,
npaun
reviewed
Mar 20, 2024
Comment on lines
+11
to
+12
| if not (from_trip_id and to_trip_id): | ||
| continue |
There was a problem hiding this comment.
Suggested change
| if not (from_trip_id and to_trip_id): | |
| continue | |
| if not (from_trip_id and to_trip_id): | |
| continue | |
I'm not a stickler for it but I usually leave a blank line between different if blocks
npaun
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a transfer is in_seat, passengers should be able to embark at the last stop of the from_trip of the continuation, and disembark at the first stop of the to_trip of the continuation. Update the stop_times to reflect this.
Update a simple test case to ensure that this transformation is applied.