Added a test to warn on short names #165
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav
changed the title
Closed
cbizon
reviewed
Jul 18, 2023
| @@ -1,4 +1,6 @@ | |||
| { | |||
| "warn_on_short_names": 3, | |||
There was a problem hiding this comment.
how often does this happen? I would assume we're going to see zillions of warnings...
There was a problem hiding this comment.
769,715 times in 2023jul9, and 1,857,487 times in the current Babel... so yeah, probably too often to be useful :(. I'll close this PR and make a new one just to fix the loophole in synonym uniquification.
gaurav
added a commit
that referenced
this pull request
Jul 25, 2023
We sometimes get duplicate synonyms in the output, which I've realized is because `synonym_factory.get_synonyms()` only ensures that `(relation, synonym)` tuples are unique. I've added a `set()` to ensure that the actual synonyms are unique, too. (Split off from PR #165).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a warning for short names in the list of synonyms for a CURIE, as this could be a sign of incorrect synonyms being included in Babel. Also: we sometimes get duplicate synonyms, which I've just realized is because
synonym_factory.get_synonyms()only ensures that(relation, synonym)tuples are unique. I've added aset()to ensure that the actual synonyms are unique, too.