Skip to content

feat(action): add DELETE /actions/{action_id} with cascade - #165

Merged
eldonm merged 1 commit into
devfrom
feat/action-delete-endpoint
Sep 1, 2026
Merged

feat(action): add DELETE /actions/{action_id} with cascade#165
eldonm merged 1 commit into
devfrom
feat/action-delete-endpoint

Conversation

@Tharickv75

Copy link
Copy Markdown
Contributor

Summary

Adds a DELETE /actions/{action_id} endpoint to allow deleting an action by its ID. The endpoint enforces admin role authorization and triggers a cascade deletion (cascade=True), removing all associated child nodes before deleting the action itself. Returns a 404 ResourceNotFoundError if the action does not exist.

Related issues

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change
  • Documentation
  • Chore / tooling / CI

Checklist

  • I read CONTRIBUTING.md and (for subsystem work) the local CLAUDE.md.
  • pre-commit run --all-files passes.
  • pytest tests/ passes; I added/updated tests for new behavior.
  • Bug fixes cite file:line in the description.
  • Docs / CHANGELOG.md updated where relevant (entry under [Unreleased]).
  • No ADR was modified in place (changes of decision are written as a new, superseding ADR).

Notes for reviewers

  • Endpoint restricted to admin role (roles=["admin"]).
  • Uses await action.delete(cascade=True) in jvagent/action/endpoints.py.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Tharickv75 Tharickv75 self-assigned this Sep 1, 2026
@Tharickv75
Tharickv75 requested a review from eldonm as a code owner September 1, 2026 15:36
@eldonm
eldonm changed the base branch from main to dev September 1, 2026 15:50
@eldonm
eldonm merged commit 063385e into dev Sep 1, 2026
3 checks passed
@eldonm
eldonm deleted the feat/action-delete-endpoint branch September 1, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants