Error output supplemented by error from Twitch #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Release] Version 3.5.0
[Release] Version 3.5.2
[Release] Version 3.6.0
Changelog: - Fixes an ArgumentNullException when not providing a playlist id for the GetPlaylists API call
- TwitchLib now builds on .NET 6 SDK - Fix various issues with GetStreamMarkers API - Fix Predictors models (TwitchDev Docs are wrong) - Added GetCharityCampaign support - Revisited the code, cleaned up unused imports and rewritten some input validation
Changelog: - Added GetChatters Helix API support - Marked Undocumented GetChatters API as obsolete - Added various new and missing scopes to AuthScope Enum - Added optional bool to determine whether to invoke FollowerService Events on startup (default: false) - Removed broken undocumented Endpoints - Fixed an issue with DeleteEventSubSubscriptionAsync to return false on success - Added XML docs to every API function call - Added EventSub Websocket Support to CreateEventSubscription - Removed Id param from GethypeTrainEvents (removed by Twitch) - Allow to query for multiple EmoteSets by Id - Allow to query for multiple redemptions by Id - Added missing query params to both Analytics API calls - Removed communityIds and type param from GetStreams (removed by Twitch)
Add missing whispers class
…tch-2 Revert "Add missing whispers class"
Changelog: - Updated dependencies - Added missing Auth subclass to ITwitchInterface - Added HttpResponse to Http related exceptions for better debugging - Added IgdbId to Games and added support for IgdbId lookup for Games - Added type parameter to GetStreams - Added tags to all related Stream models - Added UserId and UserName to GetChatters - Added GetCharityDonation support, Added Shield Mode support - Added Send Shoutout support - Added new Follower Endpoints support - Switched Follower Service to new Follwer endpoint (Breaking Change) - Reason for BanUser now defaults to string.Empty - Fixed wrong Whisper Endpoint - Fixed wrong property name in CreateCustomRewards Request - Fixed issue with force_verify in generated Auth strings by GetAuthorizationCodeUrl - Fixed UpdateUserCall using the wrong HTTP method
Syzuna
requested changes
Nov 6, 2023
There was a problem hiding this comment.
Thanks for the PR!
3 Small things from me:
- Please target the dev branch with your PR
- Could you change the message that is passed to the exception to be just sth like
$"{deserializedError.Error} - {deserializedError.Message}"? I dont think we need the other outdated parts that we had in there for ages. - Just make the method async instead of using
.Result. I think you should be able to do that as the method in that HandleWebException is called should be async already
|
@Syzuna thanks for the review! - i will fix that later on ;) |
- made HandleWebException method async - removed outdated message-content from exceptionmessage
neon-sunset
suggested changes
Nov 6, 2023
Co-authored-by: neon-sunset <neon-sunset@outlook.com>
|
The last change to make this work is to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.