Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TU-3717): Initial version #1

Merged
merged 7 commits into from
Dec 4, 2023
Merged

feat(TU-3717): Initial version #1

merged 7 commits into from
Dec 4, 2023

Conversation

mathio
Copy link
Collaborator

@mathio mathio commented Nov 19, 2023

No description provided.

@bender-bot-tf
Copy link

bender-bot-tf bot commented Nov 19, 2023

This repository does not have a CODEOWNERS file, which is a standard, and critical for many metrics at Typeform, please add one.
More info: https://www.notion.so/typeform/CODEOWNERS-679209781dfa486295279039d38ff225
If you have any doubts please contact #engineering-intelligence-team on Slack

@mathio mathio changed the title feat(NOJIRA-124): Initial version feat(NOJIRA-123): Initial version Nov 19, 2023
Copy link

@mumpo mumpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a nice to have, we could consider adding the containerSelector or iframeWrapper or something along these lines parameter that allows users to control where they put the iframe, wdyt?

.gitignore Outdated Show resolved Hide resolved
.prettierrc Outdated Show resolved Hide resolved
commitlint.config.js Outdated Show resolved Hide resolved
src/lib/open.ts Outdated Show resolved Hide resolved
src/lib/open.ts Outdated Show resolved Hide resolved
src/lib/initialize-buttons.ts Outdated Show resolved Hide resolved
src/lib/utils/get-embed-admin-url.ts Outdated Show resolved Hide resolved
src/lib/open.ts Outdated Show resolved Hide resolved
.prettierrc Outdated Show resolved Hide resolved
src/lib/open.ts Show resolved Hide resolved
Copy link

github-actions bot commented Nov 22, 2023

TypeScript adoption

Current adoption level: 99.6%

- rename `payload` to `formId` for "edit" action
- change callback payload to object with `formId` prop
- attach click action via `addEventListener`
README.md Outdated Show resolved Hide resolved
Co-authored-by: Leandro Serafim <dev.serafim@gmail.com>
@mathio mathio changed the title feat(NOJIRA-123): Initial version feat(TU-3717): Initial version Nov 28, 2023
.gitignore Show resolved Hide resolved
CODEOWNERS Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/workflows/pull-request.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@typeform-ops-gha
Copy link

[BOT] Preview available with hash a059ccb175efec030e30312fe9f41a83195f11ac here.

@mathio mathio merged commit 8215e56 into main Dec 4, 2023
3 checks passed
@mathio mathio deleted the init branch December 5, 2023 14:27
@typeform-ops-gha
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants