Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cath-refine-align doesn't respect --align-regions when writing alignments #47

Closed
tonyelewis opened this issue Oct 12, 2017 · 2 comments
Closed
Assignees

Comments

@tonyelewis
Copy link
Contributor

Performing the following:

cath-ssap --pdb-path $PDBDIR 1cuk 1bvs --align-regions 'D[1cukA03]156-203:A' --align-regions 'D[1bvsA03]149-199:A'
cath-refine-align --ssap-aln-infile 1cukA031bvsA03.list --pdb-infile $PDBDIR/1cuk --pdb-infile $PDBDIR/1bvs --align-regions 'D[1cukA03]156-203:A' --align-regions 'D[1bvsA03]149-199:A' --aln-to-ssap-file 1cukA031bvsA03.cath-refine-align.list

...generates a second alignment file in which the numbering starts at 1, not at the start of the specified domain.

@tonyelewis
Copy link
Contributor Author

I've investigated why this is a problem for cath-refine-align but not cath-superpose and I've found that it's because the alignment_context passed to use_all_alignment_outputters() by cath_superposer::superpose() here is restricted to the relevant regions, whereas the one passed (to the same function) by cath_align_refiner::refine() here isn't.

Recent commits (eg 8078efc) that make this clearer and make it easy to now switch cath-refine-align over to passing a restricted alignment_context.

But this raises the issue of why the relevant alignment outputter isn't just getting this right using the alignment_context it gets given...

@tonyelewis
Copy link
Contributor Author

Resolved by 3c2c549 and 363bdb0.

But see #48 for other issues arising from this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant