Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AdminDomains to PrivilegedUserDomains #292

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Rename AdminDomains to PrivilegedUserDomains #292

merged 2 commits into from
Oct 17, 2024

Conversation

HugoBurgess
Copy link
Contributor

PR Classification

Configuration update and vulnerability suppression.

PR Summary

Renamed configuration property from adminDomains to privilegedUserDomains and added a new vulnerability suppression.

  • continuous-deployment.yml: Updated essConfig.adminDomains to essConfig.privilegedUserDomains.
  • fss-header.component.ts and fss-header.component.spec.ts: Renamed configAdminDomains to configPrivilegedUserDomains.
  • NVDSuppressions.xml: Added suppression for cookie package version 0.6.0 with vulnerabilities CVE-2024-47764 and GHSA-pxg6-pf52-xh8x.
  • appconfig.json: Replaced adminDomains with privilegedUserDomains.

@HugoBurgess HugoBurgess requested review from rockydevnet and a team as code owners October 17, 2024 13:33
@HugoBurgess HugoBurgess changed the title Rename AdminDomains to PrivilgedUserDomains Rename AdminDomains to PrivilegedUserDomains Oct 17, 2024
@HugoBurgess HugoBurgess merged commit 3ea5efe into main Oct 17, 2024
5 checks passed
@HugoBurgess HugoBurgess deleted the Feature/Abzu-158516-admindomains branch October 17, 2024 14:16
JiviteshT
JiviteshT reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@JiviteshT JiviteshT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiviteshT JiviteshT JiviteshT left review comments

@DanOwenUKHO DanOwenUKHO DanOwenUKHO approved these changes

@rockydevnet rockydevnet Awaiting requested review from rockydevnet rockydevnet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HugoBurgess @JiviteshT @DanOwenUKHO