Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HYC-1937 - Expand Migration Utility to Include Matomo Stats #1119

Merged
merged 25 commits into from
Sep 25, 2024
Merged

HYC-1937 - Expand Migration Utility to Include Matomo Stats #1119

merged 25 commits into from
Sep 25, 2024

Conversation

davidcam-src
Copy link
Contributor

@davidcam-src davidcam-src commented Sep 23, 2024 •
edited
Loading

https://unclibrary.atlassian.net/browse/HYC-1937

  • Removed helpers from download analytics behavior, using ENV variables instead
  • WorkUtilsHelper now makes separate queries for the work and fileset data
  • ListWorkStatInfo function now calls helpers depending on the data source in the DownloadStatsMigrationService (fetch_matomo_stats and cache_stats)
  • Test class for DownloadStatsMigrationService uses a case statement to validate list_work_stat_info and migrate_to_new_table work as expected for each source

@davidcam-src
update rake task
6430480
@davidcam-src
expand test suite, update arguments
26efb60
@davidcam-src
error handling for unsupported sources
38968ad
@davidcam-src
separate local stat aggregation into helper
f33ec66
@davidcam-src
slight clarification for option description
8aa1891
@davidcam-src
remove wrapper functions for matomo env variables
f40ce1f
@davidcam-src
impl fetch matomo stats
f9aede4
@davidcam-src
fixture, add matomo case to existing test
5d04343
@davidcam-src
mock matomo api in tests
5978e7c
@davidcam-src
moving some code into helpers
a9e594a
@davidcam-src
new comments, some refactoring
5d0605b
@davidcam-src
move duplicate code into helper
d9f8984
@davidcam-src
removing comments, new helper
1c62860
@davidcam-src
require before and after timestamps for migrations from ga4 and matomo
d4213d0
@davidcam-src
rubocop
0e27608
@davidcam-src
update argument order
35a112d
@davidcam-src
update work utils helper
fbcd48a
@davidcam-src
update tests, work utils helper
d905050
@davidcam-src
update unit tests to accommodate work utils changes
6581c1c
@davidcam-src
update upload artifact
cbbd07d
@davidcam-src
env variable mocking
f2a7428
@davidcam-src
update test stubs, removing redundant test
6642a7e
@davidcam-src
use date inserted for dimensions queries
f6eef45
@davidcam-src davidcam-src merged commit f673b03 into main Sep 25, 2024
4 checks passed
@davidcam-src davidcam-src deleted the hyc-1937-migrate-matomo-stats branch September 25, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbpennel bbpennel bbpennel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidcam-src @bbpennel