Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HYC-1730 - Remove model fields which duplicate basic metadata #992

Merged
merged 7 commits into from
Aug 23, 2023
Merged

HYC-1730 - Remove model fields which duplicate basic metadata #992

merged 7 commits into from
Aug 23, 2023

Conversation

bbpennel
Copy link
Member

https://jira.lib.unc.edu/browse/HYC-1730

  • Remove 'use' field in favor of basic metadata 'rights_notes' field. Add expectation that rights_notes field is present for all work types
  • Remove 'access' field in favor of basic metadata 'access_right' field. Add expectation that access_right field is present for all work types

sharonluong
sharonluong reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@sharonluong sharonluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions/clarifications before I approve

app/forms/hyrax/article_form.rb Show resolved Hide resolved
app/forms/hyrax/data_set_form.rb Show resolved Hide resolved
app/forms/single_value_form.rb Show resolved Hide resolved
spec/features/create_general_spec.rb Show resolved Hide resolved
spec/features/create_honors_thesis_spec.rb Show resolved Hide resolved
spec/forms/hyrax/artwork_form_spec.rb Show resolved Hide resolved
@sharonluong sharonluong merged commit da44224 into main Aug 23, 2023
2 checks passed
@bbpennel bbpennel deleted the hyc-1730 branch October 10, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharonluong sharonluong sharonluong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbpennel @sharonluong