29 add and update functions for chemical domain endpoints #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
September 16, 2024 14:54
…list_contain()`, `get_chemicals_in_list_contain_batch()`, `get_chemicals_in_list_exact()`, `get_chemicals_in_list_exact_batch()`, `get_chemicals_in_list_start()`, `get_chemicals_in_list_start_batch()`.
…_in_list_exact_batch()`, `get_chemicals_in_list_contain_batch()`, and updated from GET to POST `get_chemical_synonym_batch()`.
…)`, `get_chemicals_in_list_exact()`, `get_chemicals_in_list_contain()`. Added parameter `gsid` to function `get_chemical_image()` and adjusted function and documentation.
6 tasks
rachmaninoffpk
requested review from
madison-feshuk,
brown-jason and
cthunes
brown-jason
reviewed
Sep 24, 2024
There was a problem hiding this comment.
- Testing the code from the vignette, chemicals_in_ccl4_exact <- get_chemicals_in_list_exact(list_name = 'CCL4', word = 'Bisphenol A') - Returns an empty list. Should the example return a populated list?
- chemical_image_by_smiles returns a large array. It would be nice to show how to take this array and either save or visualize an image.
brown-jason
approved these changes
Sep 24, 2024
…ples and exposition for visualizing chemical image files.
I just adjusted the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #29 .