Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add png with no text, no background #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cferenba
Copy link
Member

I created a png with no text and no background, and with the white stripes in the speech bubble. Adding it to the repo in case others have use for it. The stripes were added in a manual, rather hacky way, so unfortunately it's not suitable for extending to larger .pngs or to a .svg.

In the longer term we should have a .ai file of this version, but I don't know how to create that.

cc @usrse-maintainers

@cferenba
Copy link
Member Author

Meant to mention: this partly addresses #4.

@cferenba
Copy link
Member Author

Trying again, this time with the correct cc: @USRSE/usrse-maintainers

@vsoch
Copy link
Member

vsoch commented Jan 14, 2020

For others that want to see (the binary file doesn't render here):

https://raw.githubusercontent.com/USRSE/logo/add/png-nobackground/png/logo_300px_notext_nobackground.png

https://raw.githubusercontent.com/USRSE/logo/add/png-nobackground/png/logo_300px_notext_nobackground.png

Are you sure it doesn't have a background (it looks like it might? Did I get the right file?) Here is what it look like in the browser (click the link above), it's hard to see the background against white:

image

@cferenba
Copy link
Member Author

Yes, that's the right file. It's hard to tell from the github rendering that it doesn't have a background, but you can see it if you download it and view with an appropriate tool (I used Mac Preview).

@lparsons
Copy link
Member

The png looks good to me, it has a transparent background.
image

We need a vector version (svg) of this though, I'd think. The png should be an artifact generated from that "source".

@cferenba
Copy link
Member Author

We need a vector version (svg) of this though, I'd think. The png should be an artifact generated from that "source".

In the longer term I agree we should have that, but until we do, this at least gives us something.

@vsoch
Copy link
Member

vsoch commented Jan 14, 2020

Weird! I must not be used to how firefox renders transparency, your screenshots look right to me.

@lparsons
Copy link
Member

We need a vector version (svg) of this though, I'd think. The png should be an artifact generated from that "source".

In the longer term I agree we should have that, but until we do, this at least gives us something.

OK, I'll approve this, but let's leave the issue open until we get a proper svg and a png generated from that.

Copy link
Member

@lparsons lparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the issue open until a proper svg is created.

@cferenba
Copy link
Member Author

Leave the issue open until a proper svg is created.

Sounds reasonable to me.

@cferenba
Copy link
Member Author

I never did merge this - is one approval sufficient here, or do I need another?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants