This repository has been archived by the owner on Mar 30, 2023. It is now read-only.
Forward Response Content AND Status #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of just an Object. Returning an object is not sufficient as many REST api calls use HTTP status alone to indicate the success, or failure, of an operation (i.e. 204 No Content). I've also added RestProxyResponseErrorHandler, a ResponseErrorHandler which is always used and does nothing, but it does highlight some important assumptions: RestProxy's sole responsibility is to relay requests and responses. It's up to the client to deal with responses, whether they are successes or errors. RestProxyServiceImpl has also been modified to allow any content type and to only attach a body when the request has a content length greater than zero.
| final String contentType = request.getHeader(HttpHeaders.CONTENT_TYPE); | ||
| if(inputStream != null && MediaType.APPLICATION_JSON_VALUE.equals(contentType)) { | ||
| final String contentType = request.getContentType(); | ||
| int contentLength = request.getContentLength(); |
There was a problem hiding this comment.
👍 Looks like it should fix the brittleness around content type (e.g. application/json;charset=utf-8)
|
👍 |
nblair
added a commit
that referenced
this pull request
Sep 8, 2015
Forward Response Content AND Status
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify service and dao layers to return a ResponseEntity instead of just an Object.
Returning an object is not sufficient as many REST api calls use HTTP status alone to indicate the success, or failure, of an operation (i.e. 204 No Content).
I've also added RestProxyResponseErrorHandler, a ResponseErrorHandler which is always used and does nothing, but it does highlight some important assumptions:
RestProxy's sole responsibility is to relay requests and responses.
It's up to the client to deal with responses, whether they are successes or errors.
RestProxyServiceImpl has also been modified to allow any content type and to only attach a body when the request has a content length greater than zero.