Add project baseconfig - #147
Open
Luffy2004-c wants to merge 39 commits into
Open
Conversation
Undertone0809
requested changes
Dec 21, 2024
Owner
There was a problem hiding this comment.
commmit_message_history 的功能和正常的 commit_template 你觉得是互斥的吗？
个人感觉从效果上两种模式的互斥的，会相互干扰。
Owner
There was a problem hiding this comment.
需要讨论一下，得出一个结论，因为如果是互斥着，意味着这部分的逻辑和对应的单测需要更新一下 @Luffy2004-c
Owner
|
Undertone0809
requested changes
Jan 15, 2025
…obtaining configuration, and optimize the command help information.
…avoid accidental modifications.
…tion priority and create guidelines for project-level configuration.
…-c/gcop into add-project-baseconfig
…n logic to use the new configuration.
Undertone0809
requested changes
Feb 7, 2025
Undertone0809
requested changes
Feb 7, 2025
|
|
||
| def check_model_config(self) -> bool: | ||
| if ( | ||
| self.model_name == "provider/name,eg openai/gpt-4o" |
Owner
There was a problem hiding this comment.
如果你 default config 是一个 py 变量的话，而不是 json 文件，这里就可以直接用 if self.model_name == DEFAULT_CONF.model_name
- Rename `default_config` to `DEFAULT_CONFIG` for consistency - Remove JSON file handling and replace with direct dictionary definition - Enhance documentation and structure of `GcopConfig` and `ModelConfig` - Improve configuration loading and merging logic These changes aim to make the configuration management system more maintainable and easier to understand, without changing its core functionality.
- Delete default_config.json file - Remove unused configuration settings This change is part of a cleanup effort to remove outdated or unused configuration files, simplifying the project structure and reducing potential confusion.
…-c/gcop into add-project-baseconfig
TestGru AssignmentSummary
Files
Tip You can |
Owner
|
@Luffy2004-c can use https://github.com/Undertone0809/conftier to refactor it. |
- Implement ModelConfig class for AI model configuration - Add GcopConfig class for overall application configuration - Include validation method for model configuration These classes provide a structured way to manage application configuration with proper type hints and default values. The ModelConfig includes validation to ensure example values are not used in production.
Undertone0809
requested changes
May 1, 2025
| - Version control information (latest tag, branch count, untracked files) | ||
| - Advanced details (submodules, latest merge commit, file type statistics) | ||
|
|
||
| ### `gcop init-project` |
Owner
There was a problem hiding this comment.
Seems I have not found the detail use cases of project and user cases. You can create a new case of custom git commit message template when a team need to use.
It seems that I haven't found the detailed use cases of the [The advantages of project config] use cases yet.
When the team needs to use it, you can create a new custom git commit message template. --> This case can be displayed in docs.
Undertone0809
requested changes
May 1, 2025
| typer.echo("No project config found") | ||
|
|
||
|
|
||
| @app.command(name="set-config") |
Owner
There was a problem hiding this comment.
Need to assert schema for every key.
- Implement is_key_in_config function to check nested keys - Validate keys in set_config command before processing - Improve error handling for invalid config keys This change prevents setting invalid configuration keys by validating them against the config schema first. It handles both dataclass attributes and dictionary keys for nested config structures.
…-c/gcop into add-project-baseconfig
- Added `install-docs` target to Makefile for easier documentation setup. - Renamed `run-docs` to `start-docs` for clarity. - Expanded documentation on project-based configuration, including a real-world example for standardizing commit messages. - Improved configuration display in the `show_config` function to include merged effective configuration and better error handling for missing configs. - Updated test descriptions for clarity and consistency.
Undertone0809
force-pushed
the
add-project-baseconfig
branch
from
May 24, 2025 14:25
2412432 to
21d6173
Compare
Undertone0809
force-pushed
the
add-project-baseconfig
branch
from
May 24, 2025 14:31
691a9d7 to
6d5dc9b
Compare
Undertone0809
requested changes
May 24, 2025
Undertone0809
left a comment
Undertone0809
left a comment
Owner
There was a problem hiding this comment.
Current situation: If project config is not written with model config, I will give me a default config
Ideally: project config If model config is not written, project model config should be empty, or there is no model field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add project baseconfig
Related Issue
#126
Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.make codestyle.