comments:

Uniswap · May 9, 2024 · c230363 · c230363
1 parent 53e4534
commit c230363
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 10 deletions.
diff --git a/.forge-snapshots/create new liquidity to same position, different salt.snap b/.forge-snapshots/create new liquidity to same position, different salt.snap
diff --git a/src/libraries/Position.sol b/src/libraries/Position.sol
@@ -38,7 +38,7 @@ library Position {
 
         /// @solidity memory-safe-assembly
         assembly {
-            mstore(0x26, salt) // // [0x26, 0x46)
+            mstore(0x26, salt) // [0x26, 0x46)
             mstore(0x06, tickUpper) // [0x23, 0x26)
             mstore(0x03, tickLower) // [0x20, 0x23)
             mstore(0, owner) // [0x0c, 0x20)

diff --git a/test/ModifyLiquidity.t.sol b/test/ModifyLiquidity.t.sol
@@ -179,12 +179,6 @@ contract ModifyLiquidityTest is Test, Deployers, GasSnapshot {
 
         modifyLiquidityRouter.modifyLiquidity(simpleKey, LIQ_PARAM_SALT, ZERO_BYTES);
         snapLastCall("create new liquidity to a position with salt");
-
-        IPoolManager.ModifyLiquidityParams memory samePositionNewSalt = LIQ_PARAM_SALT;
-        samePositionNewSalt.salt = hex"BEEF";
-
-        modifyLiquidityRouter.modifyLiquidity(simpleKey, samePositionNewSalt, ZERO_BYTES);
-        snapLastCall("create new liquidity to same position, different salt");
     }
 
     function test_gas_modifyLiquidity_updateSamePosition_withSalt() public {

diff --git a/test/PoolManager.t.sol b/test/PoolManager.t.sol
@@ -2,7 +2,6 @@
 pragma solidity ^0.8.20;
 
 import {Test} from "forge-std/Test.sol";
-import {Vm} from "forge-std/Vm.sol";
 import {IHooks} from "../src/interfaces/IHooks.sol";
 import {Hooks} from "../src/libraries/Hooks.sol";
 import {IPoolManager} from "../src/interfaces/IPoolManager.sol";

diff --git a/test/libraries/Position.t.sol b/test/libraries/Position.t.sol
@@ -9,7 +9,7 @@ contract PositionTest is Test {
 
     mapping(bytes32 => Position.Info) internal positions;
 
-    function test_get_fuzz(address owner, int24 tickLower, int24 tickUpper, bytes32 salt) public {
+    function test_get_fuzz(address owner, int24 tickLower, int24 tickUpper, bytes32 salt) public view {
         bytes32 positionKey = keccak256(abi.encodePacked(owner, tickLower, tickUpper, salt));
         Position.Info storage expectedPosition = positions[positionKey];
         Position.Info storage position = positions.get(owner, tickLower, tickUpper, salt);