Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor modifyLiquidity function in Pool #604

Merged
merged 4 commits into from
May 11, 2024

Conversation

shuhuiluo
Copy link
Contributor

Related Issue

Which issue does this pull request resolve?

Description of changes

This change optimizes the modifyLiquidity function in the Pool.sol file. Local variables were moved, improving code readability and making the code more cohesive. Variables in memory were moved on the stack, improving performance. Corresponding snapshot values were also updated to reflect these changes.

This change optimizes the `modifyLiquidity` function in the Pool.sol file. Local variables were moved, improving code readability and making the code more cohesive. Variables in memory were moved on the stack, improving performance. Corresponding snapshot values were also updated to reflect these changes.
hensha256
hensha256 previously approved these changes May 8, 2024
Copy link
Contributor

@hensha256 hensha256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hensha256 hensha256 merged commit 8dfc536 into Uniswap:main May 11, 2024
5 of 6 checks passed
@shuhuiluo shuhuiluo deleted the refactor-modify-liquidity branch May 11, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants