Pool tests #726
Open
Pool tests #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forge code coverage:
|
hensha256
reviewed
May 31, 2024
| @@ -456,17 +456,17 @@ library Pool { | |||
| } | |||
|
|
|||
| /// @notice Donates the given amount of currency0 and currency1 to the pool | |||
| function donate(State storage state, uint256 amount0, uint256 amount1) internal returns (BalanceDelta delta) { | |||
| uint128 liquidity = state.liquidity; | |||
| function donate(State storage self, uint256 amount0, uint256 amount1) internal returns (BalanceDelta delta) { | |||
hensha256
reviewed
May 31, 2024
hensha256
requested changes
May 31, 2024
| state.donate(amount0, amount1); | ||
|
|
||
| test_fuzz_modifyLiquidity(sqrtPriceX96, protocolFee, lpFee, params); | ||
| state.donate(amount0, amount1); |
There was a problem hiding this comment.
can you add checks for state changes after the donation?
| }) | ||
| ); | ||
|
|
||
| state.swap(params); |
There was a problem hiding this comment.
would be great to assert the return parameters f swap are as expected - it returns the protocol fee, swap fee etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
Description of changes