chore: rename instances of "delta" to "deltas" #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just renaming the variables generally does not cause such a large gas difference |
|
these gas snapshots changed regardless of the name change (just cloning main and running forge test) |
Do you run using --isolate? |
|
ah ok got it thanks |
snreynolds
requested changes
Jun 11, 2024
Jun1on
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
snreynolds
previously approved these changes
Jun 17, 2024
snreynolds
requested changes
Jun 18, 2024
snreynolds
reviewed
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
BalanceDelta and BeforeSwapDelta are custom types of 2 int128s packed into a single 32 byte slot. However, other contexts like CurrencyDelta refer to a single value.
This singular naming scheme is confusing.
Description of changes
Rename BalanceDelta, BeforeSwapDelta, and other "delta" namings to plural form.
Rename hook flags to "ReturnDeltas" except for afterSwap (which only returns one delta).