gas limit as percentage #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
commented
Aug 30, 2024
| // SPDX-License-Identifier: GPL-2.0-or-later | ||
| pragma solidity ^0.8.0; | ||
|
|
||
| /// @title For calculating a percentage of an amount, using bips |
There was a problem hiding this comment.
This is copied across from periphery now that its been audited.
|
Forge code coverage:
|
saucepoint
reviewed
Aug 30, 2024
Comment on lines
-29
to
+33
| constructor(uint256 _controllerGasLimit) Owned(msg.sender) { | ||
| controllerGasLimit = _controllerGasLimit; | ||
| } | ||
| constructor() Owned(msg.sender) {} |
snreynolds
reviewed
Aug 30, 2024
|
|
||
| /// @inheritdoc IProtocolFees | ||
| mapping(Currency currency => uint256 amount) public protocolFeesAccrued; | ||
|
|
||
| /// @inheritdoc IProtocolFees | ||
| IProtocolFeeController public protocolFeeController; | ||
|
|
||
| uint256 private immutable controllerGasLimit; | ||
| // a percentage of the block.gaslimit denoted in basis points, used as the gas limit for fee controller calls | ||
| // 100 bps is 1%, at 30M gas, the limit is 300K |
There was a problem hiding this comment.
Are we fine with this number?
This is what we use for subscribers on periphery?
There was a problem hiding this comment.
yeah it seemed reasonable here too. 300k would be a lotttttttt. arguably id be happy to go with smaller lol
saucepoint
reviewed
Aug 30, 2024
I wrote tests for this in periphery - maybe let's transfer them over @hensha256 ? |
add tests
saucepoint
reviewed
Sep 3, 2024
saucepoint
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.