Remove mandatory viaIR #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forge code coverage:
|
snreynolds
reviewed
Sep 5, 2024
| @@ -265,13 +265,20 @@ library Pool { | |||
| } | |||
|
|
|||
| struct SwapParams { | |||
| int256 amountSpecified; | |||
There was a problem hiding this comment.
does this ordering change matter?
There was a problem hiding this comment.
we removed the cached exactInput = params.amountSpecified < 0, and are now using params.amountSpecified < 0 in place of the cached variable
making it the first element in the struct avoids the need of offset calculations
hensha256
reviewed
Sep 5, 2024
hensha256
reviewed
Sep 5, 2024
src/libraries/Pool.sol
Outdated
| // a swap fee totaling MAX_SWAP_FEE (100%) makes exact output swaps impossible since the input is entirely consumed by the fee | ||
| if (swapFee >= SwapMath.MAX_SWAP_FEE) { | ||
| if (!exactInput) { | ||
| // if not exactInput | ||
| if (!(params.amountSpecified < 0)) { |
There was a problem hiding this comment.
Suggested change
| if (!(params.amountSpecified < 0)) { | |
| if (params.amountSpecified >= 0) { |
might be better?
hensha256
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Mandatory viaIR sucks 💯
Description of changes