Ut 148/downcast fbx objects #302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoithudson
requested review from
vkovec and
benoithudson
and removed request for
vkovec and
benoithudson
| %rename("%s", %$isclass) FbxClassId; | ||
| // %rename("%s", %$isclass) FbxClassIdInfo* ; | ||
|
|
||
| %rename("%s") FbxClassId::FbxClassId; |
There was a problem hiding this comment.
This is pulling in all the constructors, and one of them has an type we don't map -- so you get a SWIGTYPE.
| } | ||
|
|
||
| System.IntPtr p = NativeMethods.FbxObject_GetRuntimeClassId(new System.Runtime.InteropServices.HandleRef(null, cPtr)); | ||
| string name = NativeMethods.FbxClassId_GetName(new System.Runtime.InteropServices.HandleRef(null, p)); |
There was a problem hiding this comment.
3 memory allocations per downcast... Let's optimize this on Monday.
| default: | ||
| break; | ||
| } | ||
| // we failed to get a match, return a bland FbxObject. |
There was a problem hiding this comment.
I take it the TODO is to repeat the switch but on the parent class?
There was a problem hiding this comment.
yes, I have a prototype that has not yet been committed.
|
Félix Bourbonnais seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
I need an FBX importer for runtime, so this MR would be very helpful. Any plans on merging this? |
|
Anyone? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.