Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-0000: Add Easing option to CinemachineSplineRoll #1016

Merged
merged 13 commits into from
Jul 30, 2024

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Jul 10, 2024

Purpose of this PR

Solves the problem raised by a client that there is no way to smoothly roll the camera on a spline.
https://discussions.unity.com/t/replicating-cm2s-smoothpath-in-cm3s-splines/952265/20

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

low

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 26.95%. Comparing base (e5a39a9) to head (eee8004).

Files Patch % Lines
...achine/Runtime/Behaviours/CinemachineSplineRoll.cs 0.00% 12 Missing ⚠️
...hine/Editor/Editors/CinemachineSplineRollEditor.cs 0.00% 3 Missing ⚠️
...emachine/Runtime/Core/SplineContainerExtensions.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                              Coverage Diff                               @@
##           dev/add-CinemachineVirtualCameraBaseEditor    #1016      +/-   ##
==============================================================================
- Coverage                                       26.96%   26.95%   -0.02%     
==============================================================================
  Files                                             254      254              
  Lines                                           28425    28439      +14     
==============================================================================
  Hits                                             7666     7666              
- Misses                                          20759    20773      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glabute glabute requested review from eakesy and sim-bz July 19, 2024 17:27
Base automatically changed from dev/add-CinemachineVirtualCameraBaseEditor to main July 30, 2024 13:35
@glabute glabute merged commit 3093a6f into main Jul 30, 2024
3 of 48 checks passed
@glabute glabute deleted the dev/splineroll-easing branch July 30, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants