CMCL-1606: TargetPositionCache needs to be public #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sébastien Duverne <55094336+sebastienduverne@users.noreply.github.com>
sebastienduverne
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Custom Cinemachine classes were prevented from supporting CInemachine's Timeline cached scrubbing feature because the necessary API was internal.
Solution was to make public the following two static methods:
TargetPositionCache.GetTargetPosition()andTargetPositionCache.GetTargetRotation()Testing status
Documentation status
Technical risk
0
Comments to reviewers
Just made 2 static methods public. There is a repro project in the bug report that can be used to test.