New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMCL-1506: group framing fixes #893

Merged

glabute merged 1 commit into main from dev/more-group-framing-fixes

Aug 8, 2023

Collaborator

glabute commented Aug 8, 2023

Purpose of this PR

nullrefs in log when a referenced group is deleted
nullrefs in group framing inspector when entering playmode
group size gameview indicator was incorrect
remove GroupFraming.FramingOffset setting - can use Recomposer for that.

Testing status

Added an automated test
Passed all automated tests
Manually tested

Documentation status

Updated CHANGELOG
Updated README (if applicable)
Commented all public classes, properties, and methods
Updated user documentation

Technical risk

low


          group framing: nullrefs, remove FramingOffset, improve gameview indic…

b339a7d

…ator

glabute merged commit 34f2201 into main

1 check passed

glabute deleted the dev/more-group-framing-fixes branch

August 8, 2023 12:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet