Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-0000: Add ThirdPersonWithAimMode sample #894

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Aug 25, 2023

Purpose of this PR

Added new sample showing how to implement a ThirdPerson FreeLook camera with a user-activated aim mode.
Also shows how to make a custom CinemachineManagerCamera that manages the Aim mode.

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

Low - just samples

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e2bf518) 21.06% compared to head (1ac2830) 21.06%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #894   +/-   ##
=======================================
  Coverage   21.06%   21.06%           
=======================================
  Files         244      244           
  Lines       27428    27428           
=======================================
  Hits         5778     5778           
  Misses      21650    21650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AntoineCharton AntoineCharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@glabute glabute merged commit f07bc68 into main Aug 25, 2023
1 check passed
@glabute glabute deleted the dev/ThirdPersonAimMode-sample branch August 25, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants