Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-1517: Fix ListView inspectors #903

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Oct 2, 2023

[Delete any line or section that does not apply]

Purpose of this PR

ListView inspectors are broken on Unity 2022.3.9f1:

  1. ClearShot child cameras have invalid warning icons in the inspector
  2. SequencerCamera does not populate the camera drop-down in the instruction list
  3. InputAxisController editor is missing foldout arrows on the Driven Axes items

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

[Overview of how documentation is affected by this change. If there is no effect on documentation, explain why. Otherwise, state which sections are changed and why.]

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

low

Copy link
Contributor

@AntoineCharton AntoineCharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

There is this bug with buttons but it's on the UI Element side. Those changes are fine.
Oct-02-2023 14-45-03

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (cbbc72d) 21.05% compared to head (a58b210) 21.05%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
- Coverage   21.05%   21.05%   -0.01%     
==========================================
  Files         244      244              
  Lines       27445    27453       +8     
==========================================
  Hits         5779     5779              
- Misses      21666    21674       +8     
Files Coverage Δ
...achine/Editor/Editors/InputAxisControllerEditor.cs 27.00% <0.00%> (+0.26%) ⬆️
...machine/Editor/Utility/CmCameraInspectorUtility.cs 0.00% <0.00%> (ø)
...Editor/Editors/CinemachineBlenderSettingsEditor.cs 0.00% <0.00%> (ø)
...Editor/Editors/CinemachineSequencerCameraEditor.cs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glabute glabute merged commit 31b2b50 into main Oct 2, 2023
6 of 8 checks passed
@glabute glabute deleted the dev/ListView-inspectors-are-broken branch October 2, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants