Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-1533: address UX comments from design team #910

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Nov 15, 2023

Purpose of this PR

After a demo of CM 3, the design team (Christine Rivard) raised some concerns about UX idiosyncrasies.

Met with Julien Didierjean to work out a plan and settled on these interventions:

  • CinemachineCamera inspector: change the text of the Procedural Motion header to something that better suggests that the dropdowns are helpers to manage the sibling components. We will use Set Procedural Components
  • Add visible text to the blank dropdown next to the lens FOV field. Text will say Palette. Update the tooltip accordingly, eliminating use of the word "preset" which can be confused with component presets.
  • Add a clarifying helpbox to procedural component inspectors in the case where multiple components are added for the same pipeline slot (issue came to light in the demo). Helpbox will indicate that the extra components are redundant and will be ignored.

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

low

@glabute glabute merged commit e7ec0e4 into main Nov 17, 2023
8 checks passed
@glabute glabute deleted the dev/UX-cleanup branch November 17, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant