chore: Asteroids internal to experimental project sync #199
+1,967
−798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -158,6 +158,10 @@ private void Update() | |||
|
|
|||
| private void UpdateInput() | |||
There was a problem hiding this comment.
I see that there was a previous version of this method below. We could remove that version?
| @@ -49,23 +49,52 @@ public override void OnNetworkSpawn() | |||
|
|
|||
There was a problem hiding this comment.
I believe some unused methods & class variables can be removed here.
| @@ -0,0 +1,149 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Could this best serve inside testproject or the internal project? It's unclear what to do inside the SerializationValidation scene, and if it's a validator of features, and not necessarily a use-case it might be best kept internally? Thoughts?
If it needs to be added to the project, this scene needs to be added to the Scene List in BuildSettings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the experimental public asteroids project with the most recent updates to the internal asteroids project based on the most recent fixes and updates for NGO v2.0.0-pre.3 and the MPS SDK v1.0.0-pre.1 updates.
Issue Number(s)
A long list of issues resolved internally and verified fixed over past two play tests.
Contribution checklist