Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on unbounded-delays for riscv64 #371

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

felixonmars
Copy link
Contributor

64-bit RISC-V should fall into the same case in
#344 and should be added here. Tested locally.

felixonmars added a commit to felixonmars/archriscv-packages that referenced this pull request Jun 22, 2023
Don't depend on unbounded-delays for riscv64.

Upstreamed as UnkindPartition/tasty#371
felixonmars added a commit to felixonmars/archriscv-packages that referenced this pull request Jun 22, 2023
Don't depend on unbounded-delays for riscv64.

Upstreamed as UnkindPartition/tasty#371
@Bodigrim
Copy link
Collaborator

$ cabal check
...
Warning: Unknown architecture name 'riscv64'
Warning: Hackage would reject this package.

@felixonmars you need to raise a Cabal PR first, adding a new architecture.

@felixonmars
Copy link
Contributor Author

I actually thought I did... Now opened as haskell/cabal#9062

@Bodigrim
Copy link
Collaborator

@amesgen @TerrorJack any ideas what's up with our WASM CI job?

@amesgen
Copy link
Contributor

amesgen commented Jun 24, 2023

@amesgen @TerrorJack any ideas what's up with our WASM CI job?

Ah sorry, this is due to a bindist artifact expiration. I have an upstream MR to fix this properly in ghc-wasm-meta. This should be merged soon-ish; will create a PR as soon as it. To fix this immediately, one can bump

GHC_WASM_META_REV: 5ad5e045f52609eab12c7e09ed9b110980807957

to bd9533e34df53694a4c7e4102fced1fdc0596024, do you want to do this here or shall I create a PR?

@Bodigrim
Copy link
Collaborator

It would be great if you raise a separate PR, thanks.

@amesgen amesgen mentioned this pull request Jun 24, 2023
@Bodigrim
Copy link
Collaborator

Unfortunately, this would have to wait not only until Cabal 3.12 release itself (which is soon), but until Hackage upgrades to it.

64-bit RISC-V should fall into the same case in
UnkindPartition#344 and should be added
here. Tested locally.
@Bodigrim
Copy link
Collaborator

Bodigrim commented Nov 2, 2024

Thanks, we can finally merge this now!

@Bodigrim Bodigrim merged commit 496c52f into UnkindPartition:master Nov 2, 2024
14 checks passed
@felixonmars felixonmars deleted the riscv64 branch November 2, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants