fixed quickcheck percent done error

[BebeSparkelSparkel]

closes #402

[BebeSparkelSparkel]

@Bodigrim Any thoughts on pulling this fix?

[Bodigrim]

I don't know internals of QuickCheck well enough. @MaximilianAlgehed could you possibly review?

[MaximilianAlgehed]

Probably yes. Den ons 29 maj 2024 16:41William Rusnack ***@***.***> skrev:

…

***@***.**** commented on this pull request. ------------------------------ In quickcheck/Test/Tasty/QuickCheck.hs <#419 (comment)> : > tm <- QC.newTerminal (const $ pure ()) - (\progressText -> yieldProgress emptyProgress { progressPercent = parseProgress progressText }) + $ \progressText -> do + ms <- readIORef maxSuccess + yieldProgress emptyProgress { progressPercent = 100 * parseProgress progressText / ms } Does the callback remove the need for unsafePerformIO? — Reply to this email directly, view it on GitHub <#419 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBPPQP4IHXMZ6BMISXPZSLZEXSLBAVCNFSM6AAAAABHHYAJUCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOBVGYZTCMZZHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[BebeSparkelSparkel]

Then it would probably be worth changing

[Bodigrim]

I wonder whether callback would allow to avoid all Terminal shenanigans here. Is it powerful enough?

[MaximilianAlgehed]

Callbacks get both the state and the result so it should be.

[Bodigrim]

@BebeSparkelSparkel do you need any help to make further progress here? I'd like to make a release of tasty and stuff in upcoming weeks.

[BebeSparkelSparkel]

Yes, I do not know how to test this besides the visual I added.

Also, with callbacks should shrinks be reported in the progress?

[Bodigrim]

@BebeSparkelSparkel looks good to me modulo two suggestions above.

[BebeSparkelSparkel]

Done pull

[Bodigrim]

Thanks, that's great.