Implement --quickcheck-timeout for individual tests within a property #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed for additional escape sequence" This reverts commit b152a0b. In fact, unless in Emacs, \r is not sufficient to clear the whole line.
|
Looks great! Just ran it on a toy project |
phadej
reviewed
Jul 18, 2024
| @@ -29,7 +29,7 @@ library | |||
| other-extensions: GeneralizedNewtypeDeriving, DeriveDataTypeable | |||
| build-depends: base >= 4.8 && < 5, | |||
| tagged < 0.9, | |||
| tasty >= 1.5 && < 1.6, | |||
| tasty >= 1.5.1 && < 1.6, | |||
There was a problem hiding this comment.
The change does what I need, thanks!
... but
The tasty-1.5.1 on Hackage has base <0 revision made.
If I use both core and quickcheck from the repo, then cabal-install finds an install plan.
There was a problem hiding this comment.
That's expected, I'll release tasty-1.5.1.1 (or 1.5.2) soon.
andreasabel
approved these changes
Jul 19, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presumably closes #359 and #424.
@phadej @brandonchinn178 could you please give it a try?