Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add password with PDF files #392

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add password with PDF files #392

wants to merge 4 commits into from

Conversation

pprados
Copy link

@pprados pprados commented Oct 15, 2024 •
edited
Loading

Add password with PDF files.
Must be combined with PR 3721 in unstructured

@pprados pprados mentioned this pull request Oct 15, 2024
Open
@pprados pprados marked this pull request as ready for review October 15, 2024 12:20
@pprados
Copy link
Author

pprados commented Oct 24, 2024

@badGarnet can you activate the review process ?

cragwolfe
cragwolfe reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@cragwolfe cragwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this is not doing much besides argument passing, please add a test showing that works.

@pprados
Copy link
Author

pprados commented Oct 29, 2024

@cragwolfe
I add a test

@pprados
Copy link
Author

pprados commented Oct 31, 2024

@cragwolfe
Can you revu this code ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cragwolfe cragwolfe cragwolfe left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pprados @cragwolfe