Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose retry params in partition via api #3724

Merged
merged 11 commits into from
Oct 22, 2024

Conversation

pawel-kmiecik
Copy link
Contributor

This PR:

  • adds parameters to control the retry-mechanism behaviour for partition_via_api:
    retries_initial_interval: [int] = None,
    retries_max_interval: Optional[int] = None,
    retries_exponent: Optional[float] = None,
    retries_max_elapsed_time: Optional[int] = None,
    retries_connection_errors: Optional[bool] = None,
  • adds tests that check using them according to defaults

Copy link
Collaborator

@badGarnet badGarnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is effectively create a wrapper for the unstructured-client interface so my question for the design is why do we need to add this to the document processing project. This creates ambiguous boundary of the projects (is this just document processing or does it also include client interfaces to a remote service, that under the hood runs the document processing code).
The client part depends on the document processing function being complete. So putting the client function in the document processing project creates a recursion where client needs client to be complete to complete.

@pawel-kmiecik pawel-kmiecik added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 6bceac1 Oct 22, 2024
41 checks passed
@pawel-kmiecik pawel-kmiecik deleted the pawel/expose-retry-params-in-partition-via-api branch October 22, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants