Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: solved word count #594

Merged
merged 9 commits into from
Jun 28, 2024
Merged

refactor: solved word count #594

merged 9 commits into from
Jun 28, 2024

Conversation

B0berman
Copy link
Contributor

@B0berman B0berman commented Jun 27, 2024

Description

  • Use new collection solvedWords
  • Update the updateSolvedWordsCount in the api's crossword_repository to add a document in a collection instead of increasing the value
  • Update the getSolvedWordsCount in the board_info_repository to return a count the documents of the collection

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@B0berman B0berman changed the title Refactor/solved word count refactor: solved word count Jun 27, 2024
@B0berman B0berman marked this pull request as draft June 27, 2024 12:52
@B0berman B0berman marked this pull request as ready for review June 27, 2024 12:58
@jsgalarraga jsgalarraga marked this pull request as draft June 27, 2024 14:13
@jsgalarraga jsgalarraga marked this pull request as ready for review June 27, 2024 17:35
jsgalarraga
jsgalarraga previously approved these changes Jun 27, 2024
Copy link
Contributor

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsgalarraga jsgalarraga merged commit 7eb09e7 into main Jun 28, 2024
6 checks passed
@jsgalarraga jsgalarraga deleted the refactor/solved-word-count branch June 28, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants