Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: ensure gauge progress color is correct when is in danger zone #4

Merged
merged 1 commit into from
Jul 30, 2024
Merged

test: ensure gauge progress color is correct when is in danger zone #4

merged 1 commit into from
Jul 30, 2024

Conversation

jsgalarraga
Copy link
Member

Description

Added tests to ensure the gauge progress color is correct when is in the danger zone. Refactored the component to make it testable.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • 🧪 Testing
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@jsgalarraga jsgalarraga self-assigned this Jul 30, 2024
marwfair
marwfair approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsgalarraga jsgalarraga merged commit d1e170b into main Jul 30, 2024
3 checks passed
@jolexxa jolexxa deleted the test/reach-full-coverage branch July 30, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marwfair marwfair marwfair approved these changes

@jolexxa jolexxa Awaiting requested review from jolexxa

@jneschisi jneschisi Awaiting requested review from jneschisi

Assignees

@jsgalarraga jsgalarraga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsgalarraga @marwfair