Preserve trailing zero when json encode

VGirol · Sep 27, 2019 · c64c819 · c64c819
1 parent 557abef
commit c64c819
Show file tree

Hide file tree

Showing 18 changed files with 12 additions and 189 deletions.
diff --git a/scripts/build.sh b/scripts/build.sh
diff --git a/scripts/doc.sh b/scripts/doc.sh
diff --git a/scripts/infection.sh b/scripts/infection.sh
diff --git a/scripts/lint.sh b/scripts/lint.sh
diff --git a/scripts/metrics.sh b/scripts/metrics.sh
diff --git a/scripts/phan.sh b/scripts/phan.sh
diff --git a/scripts/php-no-xdebug.sh b/scripts/php-no-xdebug.sh
diff --git a/scripts/phpcpd.sh b/scripts/phpcpd.sh
diff --git a/scripts/phpcs.sh b/scripts/phpcs.sh
diff --git a/scripts/phpdox.sh b/scripts/phpdox.sh
diff --git a/scripts/phploc.sh b/scripts/phploc.sh
diff --git a/scripts/phpmd.sh b/scripts/phpmd.sh
diff --git a/scripts/phpmetrics.sh b/scripts/phpmetrics.sh
diff --git a/scripts/phpmnd.sh b/scripts/phpmnd.sh
diff --git a/scripts/phpstan.sh b/scripts/phpstan.sh
diff --git a/scripts/phpunit.sh b/scripts/phpunit.sh
diff --git a/src/Factory/BaseFactory.php b/src/Factory/BaseFactory.php
@@ -64,6 +64,7 @@ public function addToArray(string $object, $value): void
      */
     public function toJson($options = 0): string
     {
+        $options = $options | JSON_PRESERVE_ZERO_FRACTION;
         $json = json_encode($this->toArray(), $options);
 
         if ($json === false) {

diff --git a/tests/Factory/BaseFactoryTest.php b/tests/Factory/BaseFactoryTest.php
@@ -85,15 +85,17 @@ public function addToArray()
      */
     public function toJson()
     {
-        $obj = new class extends BaseFactory {
+        $obj = new class extends BaseFactory
+        {
             public function toArray(): ?array
             {
                 return [
                     'attr' => 'value with <, &, \' and ".',
                     'arr' => [
                         'first',
                         'second'
-                    ]
+                    ],
+                    'float' => 3.0
                 ];
             }
 
@@ -104,7 +106,7 @@ public function fake()
         };
 
         $json = $obj->toJson();
-        $expected = '{"attr":"value with <, &, \' and \".","arr":["first","second"]}';
+        $expected = '{"attr":"value with <, &, \' and \".","arr":["first","second"],"float":3.0}';
 
         PHPUnit::assertEquals($expected, $json);
     }
@@ -114,7 +116,8 @@ public function fake()
      */
     public function toJsonFailed()
     {
-        $obj = new class extends BaseFactory {
+        $obj = new class extends BaseFactory
+        {
             public function toArray(): ?array
             {
                 return [
@@ -141,7 +144,8 @@ public function fake()
      */
     public function fakeMemberName()
     {
-        $obj = new class extends BaseFactory {
+        $obj = new class extends BaseFactory
+        {
             public function toArray(): ?array
             {
                 return [];
@@ -189,7 +193,8 @@ public function test($name)
      */
     public function fakeValue()
     {
-        $obj = new class extends BaseFactory {
+        $obj = new class extends BaseFactory
+        {
             public function toArray(): ?array
             {
                 return [];