Allow logging in by IP address #308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many situations that this commit is untested against. Not ready for merging yet.
jalsol
force-pushed
the
truong/ip-based-login
branch
from
e18fb52
to
e8736b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change: new feature
What
This PR allows logging into the account that is mapped with the IP address in the database.
To be more specific, this PR checks whether any
Profile.ipmatches the requesting IP address.THIS PR MAY BRING BREAKING CHANGES. FURTHER TESTING IS REQUIRED.
Why
This allows a convenient login experience, especially for onsite competitions where IP addresses are controlled.
How Has This Been Tested?
Tested locally, in these cases:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.