Restore the window when a snapshot asks for it - #843
Merged
Conversation
A focus from the queue owner set Visible, brought the form to the front and activated it. None of those restores a minimised window: the taskbar button flashes and the window stays minimised. So a viewer someone had minimised was never shown the snapshot it was being told to show, and the queue filled up out of sight. Raising is the form's own business now, which is also what makes it testable, and a maximised window is left as it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A focus from the queue owner set Visible, brought the form to the front and
activated it. None of those restores a minimised window: the taskbar button flashes
and the window stays minimised. So a viewer someone had minimised was never shown
the snapshot it was being told to show, and the queue filled up out of sight.
Raising is the form's own business now, which is also what makes it testable, and a
maximised window is left as it is.