Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sectionFull conditionals #502

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Fix sectionFull conditionals #502

merged 2 commits into from
Sep 12, 2023

Conversation

JoshoTheMosho
Copy link
Contributor

Description

Fixes the conditional for the section and waitlist being full or not; if there are more people enrolled than there are spots, then the section is full and should be indicated by colouring the badge red

Closes #500

Screenshots

Before

266432929-80a927b8-272a-4432-a568-52a80d637596

After

image

Checklist

  • The code follows all style guidelines.
  • The code passes all required tests.
  • The code is documented.
  • The code includes tests.
  • I have self-reviewed my changes and have done QA.

@JoshoTheMosho JoshoTheMosho requested a review from a team as a code owner September 10, 2023 06:02
@vercel
Copy link

vercel bot commented Sep 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
courseup ❌ Failed (Inspect) Sep 10, 2023 6:35am

Copy link
Contributor

@szeckirjr szeckirjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@JoshoTheMosho JoshoTheMosho merged commit 285c5db into main Sep 12, 2023
9 of 10 checks passed
@JoshoTheMosho JoshoTheMosho deleted the josh-waitlist-tag-fix branch September 12, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Section capacities not red when there are no spots left
2 participants