VCI-688: Fix minor codesmells

VirtoCommerce · Sep 14, 2023 · 05c4a42 · 05c4a42
1 parent d8d1b82
commit 05c4a42
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/src/VirtoCommerce.Build/Build.cs b/src/VirtoCommerce.Build/Build.cs
@@ -275,12 +275,12 @@ public static Solution Solution
             var testProjects = Solution.GetProjects("*.Test|*.Tests|*.Testing");
             var outPath = RootDirectory / ".tmp";
 
-            foreach (var testProject in testProjects)
+            foreach (var testProjectPath in testProjects.Select(p=> p.Path).ToArray())
             {
-                DotNet($"add \"{testProject.Path}\" package coverlet.collector");
+                DotNet($"add \"{testProjectPath}\" package coverlet.collector");
 
                 var testSetting = new DotNetTestSettings()
-                    .SetProjectFile(testProject.Path)
+                    .SetProjectFile(testProjectPath)
                     .SetConfiguration(Configuration)
                     .SetFilter(TestsFilter)
                     .SetNoBuild(true)
@@ -1172,7 +1172,14 @@ private void CompressExecuteMethod()
                 keepFiles = TextTasks.ReadAllLines(ModuleKeepFile).ToArray();
             }
 
-            ArtifactPacker.CompressModule(ModuleOutputDirectory, ZipFilePath, ModuleManifest.Id, ModuleManifestFile, WebProject.Directory, ignoredFiles, keepFiles, _moduleContentFolders);
+            ArtifactPacker.CompressModule(options => options.WithSourceDirectory(ModuleOutputDirectory)
+                                                            .WithOutputZipPath(ZipFilePath)
+                                                            .WithModuleId(ModuleManifest.Id)
+                                                            .WithModuleManifestPath(ModuleManifestFile)
+                                                            .WithWebProjectDirectory(WebProject.Directory)
+                                                            .WithIgnoreList(ignoredFiles)
+                                                            .WithKeepList(keepFiles)
+                                                            .WithModuleContentFolders(_moduleContentFolders));
         }
         else
         {

diff --git a/src/VirtoCommerce.Build/PlatformTools/Azure/AzurePipelineArtifactsClient.cs b/src/VirtoCommerce.Build/PlatformTools/Azure/AzurePipelineArtifactsClient.cs
@@ -34,7 +34,7 @@ public Stream OpenRead(Uri address)
             }
             finally
             {
-                ((IDisposable)client)?.Dispose();
+                client?.Dispose();
             }
         }
     }