VCI-585: Fix ignoring of failures in modules installation (#89)

VirtoCommerce · Jul 10, 2023 · 65dfe33 · 65dfe33
1 parent ef3ee44
commit 65dfe33
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/VirtoCommerce.Build/PlatformTools/Build.PackageManager.cs b/src/VirtoCommerce.Build/PlatformTools/Build.PackageManager.cs
@@ -351,7 +351,18 @@ private static bool IsPlatformInstallationNeeded(string version)
                      }
                  }
 
-                 var progress = new Progress<ProgressMessage>(m => Log.Information(m.Message));
+                 var progress = new Progress<ProgressMessage>(m =>
+                 {
+                     if (m.Level == ProgressMessageLevel.Error)
+                     {
+                         Log.Error(m.Message);
+                         Assert.Fail(m.Message);
+                     }
+                     else
+                     {
+                         Log.Information(m.Message);
+                     }
+                 });
 
                  if (!SkipDependencySolving)
                  {

diff --git a/src/VirtoCommerce.Build/PlatformTools/PackageManager.cs b/src/VirtoCommerce.Build/PlatformTools/PackageManager.cs
@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.Linq;
 using Nuke.Common.IO;
-using Nuke.Common.Tools.VSWhere;
 using VirtoCommerce.Build.PlatformTools;
 
 namespace PlatformTools
@@ -45,9 +44,9 @@ public static MixedPackageManifest UpdatePlatform(MixedPackageManifest manifest,
         }
 
         public static void ToFile(ManifestBase manifest, string path = "./vc-package.json")
-        {
+        {
             SerializationTasks.JsonSerializeToFile(manifest, path);
-        }
+        }
 
         public static ManifestBase FromFile(string path = "./vc-package.json")
         {