Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VCI-769: Add a check if module url does not contain the right version #112

Merged
merged 13 commits into from
Dec 26, 2023
Merged

VCI-769: Add a check if module url does not contain the right version #112

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d80e435
VCI-151: Update docs; fix default saas portal url
krankenbro Aug 24, 2023
43ad735
Merge branch 'dev' of https://github.com/VirtoCommerce/vc-build into dev
krankenbro Sep 8, 2023
e822709
Merge branch 'dev' of https://github.com/VirtoCommerce/vc-build into dev
krankenbro Sep 12, 2023
2b997d0
Merge branch 'dev' of https://github.com/VirtoCommerce/vc-build into dev
krankenbro Sep 13, 2023
0d91a48
Merge branch 'dev' of https://github.com/VirtoCommerce/vc-build into dev
krankenbro Sep 21, 2023
f80e3cd
Merge branch 'dev' of https://github.com/VirtoCommerce/vc-build into dev
krankenbro Oct 3, 2023
aeed9a5
Merge branch 'dev' of https://github.com/VirtoCommerce/vc-build into dev
krankenbro Oct 4, 2023
4f04e90
Merge branch 'dev' of https://github.com/VirtoCommerce/vc-build into dev
krankenbro Oct 25, 2023
27f0e7b
Merge branch 'dev' of https://github.com/VirtoCommerce/vc-build into dev
krankenbro Nov 13, 2023
d117847
Merge branch 'dev' of https://github.com/VirtoCommerce/vc-build into dev
krankenbro Nov 14, 2023
5988ee6
Merge branch 'dev' of https://github.com/VirtoCommerce/vc-build into dev
krankenbro Nov 15, 2023
3b68b68
Merge branch 'dev' of https://github.com/VirtoCommerce/vc-build into dev
krankenbro Dec 14, 2023
7419d47
VCI-769: Add a check if modules url does not contain the right version
krankenbro Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/VirtoCommerce.Build/PlatformTools/Build.PackageManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,11 @@ private static bool IsPlatformInstallationNeeded(string version)

private static ManifestModuleInfo LoadModuleInfo(ModuleItem module, ManifestModuleInfo externalModule)
{
if (!externalModule.Ref.Contains(externalModule.Version.ToString()))
{
Log.Error("Error in file modules_v3.json for module {0}: Version {1} not found in Reference {2}", externalModule.Id, externalModule.Version.ToString(), externalModule.Ref);
}

var currentModule = new ModuleManifest
{
Id = module.Id,
Expand Down
Loading