PT-7293: Add a new Liquid 'where' filter to enable filtering collections #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tification templates
|
|
OlegoO
approved these changes
Nov 27, 2023
OlegoO
changed the title
artem-dudarev
requested changes
Nov 27, 2023
src/VirtoCommerce.NotificationsModule.LiquidRenderer/Filters/ArrayFilter.cs
Outdated
Show resolved
Hide resolved
src/VirtoCommerce.NotificationsModule.LiquidRenderer/Filters/ArrayFilter.cs
Outdated
Show resolved
Hide resolved
src/VirtoCommerce.NotificationsModule.LiquidRenderer/Filters/ArrayFilter.cs
Outdated
Show resolved
Hide resolved
| { | ||
| /// <summary> | ||
| /// Filter the elements of an array by a given condition | ||
| /// {% assign sorted = pages | where:"propName","==","value" %} |
There was a problem hiding this comment.
Change sorted to filtered
src/VirtoCommerce.NotificationsModule.LiquidRenderer/Filters/ArrayFilter.cs
Outdated
Show resolved
Hide resolved
tests/VirtoCommerce.NotificationsModule.Tests/UnitTests/LiquidTemplateRendererUnitTests.cs
Outdated
Show resolved
Hide resolved
| @@ -152,6 +153,51 @@ public async Task RenderAsync_ContextHasLayoutId_LayoutRendered() | |||
| Assert.Equal("header test_content footer", result); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task RenderAsync_ContextHasLayoutId_ArrayContent_LayoutRendered() | |||
There was a problem hiding this comment.
Rename to RenderAsync_FilterArray
| public async Task RenderAsync_ContextHasLayoutId_ArrayContent_LayoutRendered() | ||
| { | ||
| var layoutId = Guid.NewGuid().ToString(); | ||
| var content = @"{% capture content %} Order Number: {{customer_order.number }}, Items Catalog Name: {{ var1 = customer_order.items | where: 'CatalogId' '==' '1' | array.first }} {{ var1.name }} {% endcapture %}"; |
There was a problem hiding this comment.
Remove redundant code. (capture, order number) We need to test only filtering.
| }; | ||
|
|
||
| var result = await _liquidTemplateRenderer.RenderAsync(context); | ||
| Assert.Equal("header Order Number: 123456, Items Catalog Name: Item1 footer", result); |
There was a problem hiding this comment.
Add tests for operations other than ==.
There was a problem hiding this comment.
fixed, I added a new test using greater than
There was a problem hiding this comment.
Not fixed, there are more operations
tests/VirtoCommerce.NotificationsModule.Tests/UnitTests/LiquidTemplateRendererUnitTests.cs
Outdated
Show resolved
Hide resolved
…tification templates- update code for comments
artem-dudarev
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Liquid 'where' filter to enable filtering collections in notification templates.
This new functionality allow the users filter arrays by conditions.
Example:
We have the following json
For example, if we wanted to filter the 'users' collection using the 'userId' and retrieve the first element from the list.
The sentence to make this is :
{{ var1 = users | where: 'userId' '==' '1' | array.first }} {{ var1.name }}We filter the user collection based on the 'userId' property. When the 'userId' is 1, we retrieve the first element from the filtered results. Subsequently, we assign this result to a new variable, 'var1'. Following this, we write the user's name into the template.
Description
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/PT-7293
Artifact URL: