resolve sonar warning

VirtoCommerce · Jun 11, 2024 · 0b89f77 · 0b89f77
1 parent 90a4bb2
commit 0b89f77
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/VirtoCommerce.QuoteModule.Web/Scripts/blades/quote-detail.js b/src/VirtoCommerce.QuoteModule.Web/Scripts/blades/quote-detail.js
@@ -148,9 +148,9 @@ angular.module('virtoCommerce.quoteModule')
                     {
                         name: "quotes.commands.submit-proposal", icon: 'fa fa-check-square-o',
                         executeMethod: function () {
-                            if (blade.currentEntity.items.length == 0 ||
-                                blade.currentEntity.totals.grandTotalInclTax == 0) {
-                                var dialog = {
+                            if (blade.currentEntity.items.length === 0 ||
+                                blade.currentEntity.totals.grandTotalInclTax === 0) {
+                                var warningDialog = {
                                     id: "submitProposalWithWarning",
                                     title: "quotes.dialogs.proposal-submit-with-warning.title",
                                     message: "quotes.dialogs.proposal-submit-with-warning.message",
@@ -161,10 +161,10 @@ angular.module('virtoCommerce.quoteModule')
                                         }
                                     }
                                 };
-                                dialogService.showWarningDialog(dialog);
+                                dialogService.showWarningDialog(warningDialog);
                             }
                             else {
-                                var dialog = {
+                                var confirmationDialog = {
                                     id: "submitProposal",
                                     title: "quotes.dialogs.proposal-submit.title",
                                     message: "quotes.dialogs.proposal-submit.message",
@@ -175,7 +175,7 @@ angular.module('virtoCommerce.quoteModule')
                                         }
                                     }
                                 };
-                                dialogService.showConfirmationDialog(dialog);
+                                dialogService.showConfirmationDialog(confirmationDialog);
                             }
                         },
                         canExecuteMethod: function () {