Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote totals: use same field names as for shopping cart #123

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

asvishnyakov
Copy link
Contributor

@asvishnyakov asvishnyakov commented Oct 29, 2024

Description

Quote totals renamed in XAPI

Cart and Order has same names for the same fields in XAPI. In Quotes they was named differently and placed in totals field. This is changed (with deprecation) for easier code sharing on frontend.

Before

query {
  quote (id: "f256d664-e49c-48aa-9e54-86ae98abb402") {
    totals {
      discountTotal
      shippingTotal
      originalSubTotalExlTax
      subTotalExlTax
      grandTotalExlTax
      grandTotalInclTax
      adjustmentQuoteExlTax
    }
  }
}

After

query {
  quote (id: "f256d664-e49c-48aa-9e54-86ae98abb402") {
    discountTotal
    shippingTotal
    originalSubTotal
    subTotal
    total
    totalWithTax
    adjustment
  }
}

References

QA-test:

Jira-link:

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Quote_3.818.0-pr-123-89c2.zip

This reverts commit 9c25ce4.
@vc-ci
Copy link
Contributor

vc-ci commented Oct 29, 2024

Reveiw task created: https://virtocommerce.atlassian.net/browse/VCST-2181

Copy link

sonarcloud bot commented Oct 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants