Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when content in the blogs folders are missed in the sitemap #70

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

tatarincev
Copy link
Contributor

@tatarincev tatarincev commented Mar 19, 2024

Description

How to reproduce:

  • Add any not empty blog folder ('news' as example) to the site map as content item
  • Generate sitemap

Actual result:

  • Resulting sitemap doesn't contains any links for blog pages in the folder "news"

Expected result:

  • Resulting sitemap contains all links for blog pages in the folder "news"

References

QA-test:

Jira-link:

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Sitemaps_3.803.0-pr-70-e20f.zip
https://github.com/VirtoCommerce/vc-module-sitemaps/actions/runs/8341954445/job/22829091644

@vc-ci
Copy link
Contributor

vc-ci commented Mar 19, 2024

Reveiw task created: https://virtocommerce.atlassian.net/browse/VCST-831

@OlegoO OlegoO self-requested a review March 19, 2024 12:31
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Critical Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@ekuvirto ekuvirto merged commit 79d1d57 into dev Mar 20, 2024
4 of 5 checks passed
@ekuvirto ekuvirto deleted the bugfix/blogs-content-no-included branch March 20, 2024 13:01
@ekuvirto
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants