Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(converters): Add log warning messages indicating that converters will be deprecated in favor of those in MSstatsConvert #120

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

tonywu1999
Copy link
Contributor

@tonywu1999 tonywu1999 commented Apr 12, 2024

Motivation and Context

In this PR, we copied all MSstats converters into MSstatsConvert to simplify the software architecture w.r.t. converters. On top of sending out an announcement to users on the MSstats mailing list, we should also log a warning message to users whenever they use converters from the MSstats package.

Changes

  • Added a warning log message to every converter in MSstats that notifies users to migrate to MSstatsConvert by release 3.21

Testing

  • Verified log message is printed on RStudio screen when using one of the converters

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

… will be deprecated in favor of those in MSstatsConvert
@mstaniak
Copy link
Contributor

mstaniak commented Apr 15, 2024

I would prefer it to be a message. Does R treat "WARN" option as a message? From the perspective of tryCatch() etc

@tonywu1999
Copy link
Contributor Author

I would prefer it to be a message. Does R treat "WARN" option as a message? From the perspective of tryCatch() etc

Thanks for your input - I actually like message more too. I saw that the message command made the text red colored and more noticeable as well.

Copy link
Contributor

@devonjkohler devonjkohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good addition to the log.

Looks all set to me.

@tonywu1999 tonywu1999 merged commit bacd4d5 into devel Apr 17, 2024
1 check passed
@tonywu1999 tonywu1999 deleted the logs branch April 17, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants