Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plotly for design sample #121

Merged
merged 5 commits into from
Apr 26, 2024
Merged

plotly for design sample #121

merged 5 commits into from
Apr 26, 2024

Conversation

deril2605
Copy link
Contributor

@deril2605 deril2605 commented Apr 19, 2024

Motivation and Context

Please include relevant motivation and context of the problem along with a short summary of the solution.

Previously Plotly for design Experiment was implemented directly in MSstatsShiny, now the code has been migrated and made more robust to match like ggplot2.

Associated PR on Shiny: Vitek-Lab/MSstatsShiny#89

Changes

Please provide a detailed bullet point list of your changes.

  • Added Plotly code in designSampleSize.R
  • A new parameter to the function designSampleSizePlots, isPlotly to toggle between the plotting libraries
  • Updated documentation for the function

Testing

Please describe any unit tests you added or modified to verify your changes.

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

R/designSampleSize.R Outdated Show resolved Hide resolved
R/designSampleSize.R Outdated Show resolved Hide resolved
@tonywu1999
Copy link
Contributor

tonywu1999 commented Apr 19, 2024

Hey Deril, this looks mostly good to go, some minor comments above.

Also, could you add a basic unit test to verify that the function returns a successful response when isPlotly is set to true? A unit test should provide future devs peace of mind that they don't break your changes when they work in the same code base.

Copy link
Contributor

@devonjkohler devonjkohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all set

@devonjkohler devonjkohler merged commit db8297e into devel Apr 26, 2024
1 check passed
@tonywu1999 tonywu1999 deleted the fix-design-sample-plotly branch July 2, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants